Allow Reconciler update handler to examine old value during update #36171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcsc
added
the
no-changelog
github-actions
bot
added
application-access
database-access
github-actions
bot
requested review from
ibeckermayer,
probakowski and
smallinsky
rosstimothy
reviewed
Jan 2, 2024
smallinsky
approved these changes
Jan 3, 2024
rosstimothy
reviewed
Jan 3, 2024
tcsc
force-pushed
the
tcsc/reconciler-gets-old-value
branch
from
c66d3f3
to
fb69aa4
Compare
rosstimothy
approved these changes
Jan 4, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski and
ibeckermayer
This change allows the Reconciler `onUpdate` handler to examine the existing value of the resource being reconciled while performing the update. This allows the handler to take special action for specific changes, for example locking a user if their upstream identity provider disables the account.
tcsc
force-pushed
the
tcsc/reconciler-gets-old-value
branch
from
fb69aa4
to
8d0518b
Compare
Envek
added a commit
to Envek/teleport
that referenced
this pull request
Jan 4, 2024
…se-anon-key * origin/master: (344 commits) Undelete CreateHostUserMode_HOST_USER_MODE_DROP (gravitational#36273) allow cwd to be changed in difftest (gravitational#35946) Auth device list component (gravitational#36235) make unified resources responsive (gravitational#35961) Support running Teleport in a "hot reload" mode (gravitational#35040) Prevent deleting enum values, allow deleting enum reservations in types.proto (gravitational#36248) Remove support for legacy (Amazon Linux 2) AMIs (gravitational#36153) Bump version(s) used for teleport-lab and teleport-quickstart (gravitational#36167) Allow Reconciler update handler to examine old value during update (gravitational#36171) Validate the user still exists during account reset (gravitational#35676) ButtonTextWithAddIcon shared component (gravitational#36103) Refactor hostname resolution for SSH connections via the WebUI (gravitational#35773) add structuredClone to jest JSDOMEnvironment (gravitational#36213) fix flaky `lib/auth` cache-enabled tests (gravitational#36216) Report resource usage counts by handling heartbeat events (gravitational#35968) Reviewer bot should use the stable version of Go (gravitational#36242) RFD 0153 Resource Guidelines (gravitational#34103) Use cmp and cmpots properly in operator tests (gravitational#36215) Relax Kubernetes CRD discovery when building cache (gravitational#36214) Add Access List messages to TAG protobuf (gravitational#36176) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Reconciler update handler to examine the existiung
value of the resource being reconciled while performing the update. This
allows the handler to take special action for specific changes - for
example locking a user if their upstream identity provider disables the
account.