[v14] Validate the user still exists during account reset #36271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
bot/backport-35676-branch/v14
branch
from
0e4a0eb
to
72cbd3e
Compare
rosstimothy
force-pushed
the
bot/backport-35676-branch/v14
branch
from
72cbd3e
to
aa2e04a
Compare
Prior to this, any reset links created before a user was deleted would still be valid and when used would recreate the deleted user. With this change, the user is validated to still exist prior to honoring the reset request and if the user no longer exists any remaining reset tokens are deleted.
rosstimothy
force-pushed
the
bot/backport-35676-branch/v14
branch
from
aa2e04a
to
196b08a
Compare
jentfoo
approved these changes
Jan 4, 2024
zmb3
approved these changes
Jan 4, 2024
strideynet
approved these changes
Jan 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #35676 to branch/v14
changelog: Prevent deleted users from using account reset links created prior to the user being deleted