Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Add bot field to certificates and various usage events (#35881) #36313

Merged
merged 4 commits into from Jan 11, 2024

Commits on Jan 5, 2024

  1. Add bot field to certificates and various usage events (#35881)

    * Add bot field to certificates and various usage events
    
    This adds a new certificate extension field, `teleport-bot`, to
    certificates issued to Machine ID bot users that can definitively
    identify certificates as having been issued to a bot user.
    
    Additionally, this uses the new `Bot` identity flag to mark certain
    usage events as originating from bot users. As such, it includes a
    protobuf update from Cloud [1], which pulled in some small additional
    (mostly comment) changes.
    
    [1] gravitational/cloud#7060
    
    * Small bot flag plumbing fixes
    
    * Convert bot flag to BotName and UserKind enum
    
    This makes a few changes to the bot tagging approach:
    * The bot name is embedded in the cert rather than just true/false
    * UserKind is included in events rather than just a bot flag, to
      allow for an unspecified value for older client nodes.
    
    * Add a quick unit test for bot cert extensions
    
    * Fix outdated grpc
    
    * Include bot flag on initial certs
    
    * Log a warning and override user kind for usage records if they differ
    
    * Fix several unit tests; add a bot metadata test case
    
    * Fix unit tests with UserKind zero value
    
    * Rename SSH cert extension to use standard format
    
    Renames the `teleport-bot` extension to `bot-name@goteleport.com`,
    to better follow SSH cert extension naming conventions.
    
    * Attempt to improve unspecified userkind aggregating logic
    timothyb89 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    778edc6 View commit details
    Browse the repository at this point in the history
  2. Fix broken tests

    timothyb89 committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    77d356c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2d9bd87 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Configuration menu
    Copy the full SHA
    b1028eb View commit details
    Browse the repository at this point in the history