[v14] Web: Add auto enrolling capabilities to RDS discover flow (#35646) #36434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add discovery config endpoint * Add autoDiscoveryConfig field to meta * Hide custom label for auto discover * Pull out re-usable parts for storybook fixture * Only allow adding new traits when auto-enrolling - Existing traits is not made editable - Minor refactor: pull data from useDiscover context * Auto select integration if only one result * Skip test connection when auto enrolling Refactor setup access story * Add auto enroll toggler * Create finish component for auto discover * Add more disabled row states * Add clarifying notes * Address CRs * Finish auto discovery - When enrolling and opting for auto discovery, we need to first collect all missing vpcs to determine if its required to deploy database agents, and then create a discovery config for a discovery service - When auto deploying and opting for auto discovery, it is out scope for this iteration to allow user to define custom labels, select security groups, and "wait" for deploying all services to finish. Instead after deploy request is finished, we render a box that tells user it will take a minute to finish deploying and give a AWS dashboard link to view progress - Setup access screen is the final step (skip test connection) and we render how to setup access for both mysql and postgres since auto discovery discovers all supported engine types. * Address CR
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
* Web: Support auto discovery for self-hosted * Move doc instructions into web UI * fix test
kimlisa
force-pushed
the
lisa/v14/auto-disocver-ui
branch
from
7329304
to
9ced2ad
Compare
r0mant
approved these changes
Jan 9, 2024
gzdunek
approved these changes
Jan 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #35646 and #36027 to branch/v14
manual because conflict with test files.
test files are written differently in master from react upgrade which aren't backported.
changelog: Added auto-enrolling capabilities to RDS discover flow in the web UI.