New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document managing users, roles and accesslists through IaC #36622
Conversation
🤖 Vercel preview here: https://docs-ptogzm6cq-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-noaripxt8-goteleport.vercel.app/docs/ver/preview |
I owe you a review of this. I'll make time to provide one this week! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but overall lgtm.
docs/pages/includes/diagnostics/kubernetes-operator-troubleshooting.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change! We have how-to instructions throughout the docs for creating users and roles with tctl
, so it's nice to also have how-to instructions for other client tools as tabbed instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to review the "User and Role" and "User Types" pages later this week.
docs/pages/management/dynamic-resources/teleport-operator-helm.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review the "User Types" guide next week
docs/pages/reference/user-types.mdx
Outdated
|
||
## Local Users | ||
|
||
Local users are created directly in Teleport. They are not coming from an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expand on what "directly" means here, e.g., talking about the Auth Service backend.
Also, should we mention that local users are dynamic resources and link to the relevant docs on dynamic resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed "directly". Both local and non-local are dynamic resources and living in the Teleport backend. From a technical pov, the implementation is identical.
7c53df8
to
0b2dc27
Compare
🤖 Vercel preview here: https://docs-ch7c5ottv-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-1vvh08m7e-goteleport.vercel.app/docs/ver/preview |
🤖 Vercel preview here: https://docs-h9xl65bsx-goteleport.vercel.app/docs/ver/preview |
@ptgott I addressed most comments and responded to a couple, the PR is ready for another review |
🤖 Vercel preview here: https://docs-3kmsqckwv-goteleport.vercel.app/docs/ver/preview |
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
73de16d
to
ee67fc7
Compare
🤖 Vercel preview here: https://docs-9b9h8ah2s-goteleport.vercel.app/docs/ver/preview |
@hugoShaka See the table below for backport results.
|
* Document managing users, roles and accesslists through IaC * reformat docs/config.json * address feedback * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * align label names * address feedback * update teleportrole version --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
* Document managing users, roles and accesslists through IaC * reformat docs/config.json * address feedback * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * Apply suggestions from code review Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com> * align label names * address feedback * update teleportrole version --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
…38177) * Document managing users, roles and accesslists through IaC * reformat docs/config.json * address feedback * Apply suggestions from code review * Apply suggestions from code review * align label names * address feedback * update teleportrole version --------- Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
Closes #23097
This PR adds the following pages:
Requires a
tctl
containing those fixes: #36572