[v14] Fix routing to public addresses #36624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#36584 allowed routing to work for public addresses, however it used GetPublicAddr to retrieve the public address. types.Server can have multiple public addresses though which means routing was only ever considering the first public address defined. This updates the routing logic to use GetPublicAddrs so they are all considered.
espadolini
approved these changes
Jan 12, 2024
avatus
approved these changes
Jan 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #36617 to branch/v14
changelog: Fixed routing to nodes by their public addresses