Add Bot + GitHub Actions SSH UI Flow #37443

mcbattirola · 2024-01-29T17:59:44Z

This PR adds a new UI Flow to add Machine ID Bots through a GitHub Actions join token.

The flow is under the disabled new Bots page, added in #36845.

Since we expect new bot integration flows to be added in the future, I've added a shared folder to host components that will be reused by multiple flows (similar to how we organize Discover code).

The page Enroll New Integration has a section for Machine ID that is mostly replicated in this PR. I've implemented the new section with the intent of reusing it, but since this feature is disabled for now, I'm keeping the old MachineIDIntegrationSection component to prevent linking to the new flow. See this PR where I reverted to the original component to see what it will look like.

(~800 changes are due to story/tests)

demo:

bot-ui.mp4

Testing

The best way to test is to edit the FeatureBots so hasAccess returns true. This will enable the Bots page, and allow you to go through the UI flow via the Enroll New Bot button.

If you run teleport enterprise, make sure you have this patch https://github.com/gravitational/teleport.e/pull/3356

- in original data table view

…o mcbattirola/machine-id--bot-creation-ui-3

…tirola/machine-id--bot-creation-ui-3

* add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Update copy and minor style change --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com>

* Add endpoint to get bots by name (#37412) * Add endpoint to get bots by name * Lint * Fix test method's name Co-authored-by: Noah Stride <noah.stride@goteleport.com> --------- Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Backend supporting changes for Bot creation flow (#37348) * Add bot ui labels and github join token * Use strings.HasPrefix instead of includes * Add `ssh` to label * Add bot join token endpoint * Lint * Fix comment typo Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * Fix comment typo Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * Improve webUIFlowLabelKey comment --------- Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com> * add bots UI, disabled (#36845) - in original data table view * Add Bot + GitHub Actions SSH UI Flow (#37443) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Update copy and minor style change --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> * add bot edit-role flow (#37828) * add bot edit-role flow * only send masked/updated fields * Add GitHub Actions bot view (#37852) * add bots UI, disabled - in original data table view * Add bot creation UI * Remove duplicated types * add bots UI, disabled - in original data table view * Fix types and tests * Use bot join token api endpoint * Fix tests * Linting and small fixes * Fix tests * Add missing licenses * Improve styles, error messages, etc * Remove clusterId from bot routes * Undo enabling feature * Remove unused join role bot * Rename var * Reuse makeListBot * Add missing type * Revert MachineIDIntegrationSection for now * Lint * Apply suggestions from code review - fix typos Co-authored-by: Noah Stride <noah.stride@goteleport.com> * Remove kubernetes section fromm example yaml * Remove border color from reftype selector * Small changes to address code review * Use setAttempt * add try/catch block when parsing repo addresses * Improve tests;remove unecessary fragment * Use gap in flex. Fix typo * Lint fix * Drop "ex" from input placeholders * Add stories for no perm and bot picker * Add copy to explain wrkflow name limits * fix setCurentStep * Fix invalid host error rendering * Use PascalCase for error components * Improve field name validation * Remove unecessary comments * Add bot type by label * Add bot view... * Show view gh actions yaml only for gh bots * Use existing pattern for operations * Add story and missing license * Fix typos Co-authored-by: Michelle Bergquist <11967646+michellescripts@users.noreply.github.com> --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: Michelle Bergquist <11967646+michellescripts@users.noreply.github.com> * Add buttons to download and copy to clipboard content to `TextEditor` (#37333) * Add editor buttons * Set icon size * Move downloadObject to OSS * remove unused test-id * Use values from theme * Fix buttons positioning * Convert jsx files to tsx * Use const instead of var * Add z-index to buttons * Add license * Improvements to Bot resource (additional validation and label propagation) (#38013) * PRevent creating bots with an empty string role * Propagate labels to Bot user and vice versa * Extract slice declaration for nonPropagatedLabels * Fixed web tests relying on empty string roles * Use "set" instead of slice for nonPropagatedLabels * Make testing of empty string handling more thorough * add role assertions to create * Appease linter as to want/got order --------- Co-authored-by: Michelle Bergquist <michelle.bergquist@goteleport.com> * Add bot permissions and turn on feature (#37943) * Fix makeBot labels (#38176) --------- Co-authored-by: matheus <matheus.battirola@goteleport.com> Co-authored-by: Noah Stride <noah.stride@goteleport.com> Co-authored-by: Bartosz Leper <bartosz.leper@goteleport.com>

michellescripts and others added 3 commits January 24, 2024 14:40

add bots UI, disabled

c957be4

- in original data table view

Add bot creation UI

e697a0e

Remove duplicated types

f226c41

michellescripts force-pushed the michelle/bots branch 4 times, most recently from f847102 to 46f7b2e Compare January 29, 2024 22:05

add bots UI, disabled

eef9c7a

- in original data table view

michellescripts force-pushed the michelle/bots branch from 46f7b2e to eef9c7a Compare January 29, 2024 22:48

mcbattirola added 3 commits January 30, 2024 10:55

Fix types and tests

59034d6

Use bot join token api endpoint

d740502

Merge branch 'michelle/bots' of github.com:gravitational/teleport int…

5066fab

…o mcbattirola/machine-id--bot-creation-ui-3

michellescripts force-pushed the michelle/bots branch 8 times, most recently from f33b15e to 7671f0f Compare February 1, 2024 16:50

Base automatically changed from michelle/bots to master February 1, 2024 17:27

mcbattirola added 9 commits February 1, 2024 14:54

Merge branch 'master' of github.com:gravitational/teleport into mcbat…

0da9b38

…tirola/machine-id--bot-creation-ui-3

Merge branch 'master' of github.com:gravitational/teleport into mcbat…

8e8a75d

…tirola/machine-id--bot-creation-ui-3

Fix tests

8f07eff

Linting and small fixes

4b382f7

Fix tests

371a197

Add missing licenses

274e756

Merge branch 'master' of github.com:gravitational/teleport into mcbat…

cbf1aa9

…tirola/machine-id--bot-creation-ui-3

Improve styles, error messages, etc

a25e300

Remove clusterId from bot routes

4e7a218

mcbattirola and others added 6 commits February 6, 2024 16:29

fix setCurentStep

4855b8b

Fix invalid host error rendering

fe41f4e

Use PascalCase for error components

21e5b0f

Improve field name validation

a598bc2

Remove unecessary comments

342951f

Merge branch 'master' into mcbattirola/machine-id--bot-creation-ui-3

b413fdf

strideynet approved these changes Feb 7, 2024

View reviewed changes

mcbattirola requested a review from jimbishopp February 7, 2024 12:29

jimbishopp approved these changes Feb 7, 2024

View reviewed changes

public-teleport-github-review-bot bot removed request for klizhentas, r0mant, timothyb89 and michellescripts February 7, 2024 17:17

mcbattirola and others added 2 commits February 8, 2024 09:01

Merge branch 'master' into mcbattirola/machine-id--bot-creation-ui-3

68e32e6

Update copy and minor style change

54cb535

mcbattirola added this pull request to the merge queue Feb 8, 2024

Merged via the queue into master with commit 475e5c7 Feb 8, 2024
34 checks passed

mcbattirola deleted the mcbattirola/machine-id--bot-creation-ui-3 branch February 8, 2024 12:58

mcbattirola mentioned this pull request Feb 13, 2024

Reuse BotTiles component on Enroll New Integration page #38142

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Bot + GitHub Actions SSH UI Flow #37443

Add Bot + GitHub Actions SSH UI Flow #37443

mcbattirola commented Jan 29, 2024 •

edited

Add Bot + GitHub Actions SSH UI Flow #37443

Add Bot + GitHub Actions SSH UI Flow #37443

Conversation

mcbattirola commented Jan 29, 2024 • edited

Testing

mcbattirola commented Jan 29, 2024 •

edited