fix: Do not wrap io.EOF intercepted by stream Sends #37647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmb3
reviewed
Feb 1, 2024
zmb3
approved these changes
Feb 1, 2024
rosstimothy
approved these changes
Feb 1, 2024
public-teleport-github-review-bot
bot
removed request for
avatus,
flyinghermit and
Joerger
|
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Feb 1, 2024
* Verify that intercepted stream Sends wrap io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends * Use a helper func, fix duplicate Send/Recv calls * Fix typo
codingllama
added a commit
that referenced
this pull request
Feb 1, 2024
* Verify that intercepted stream Sends wrap io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends * Use a helper func, fix duplicate Send/Recv calls * Fix typo
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* fix: Do not attempt relogin on remote BadParameter errors (#36866) * fix: Do not attempt relogin on trace.BadParameterError * Special case remote errors in IsErrorResolvableWithRelogin * Do not wrap Recv EOF errors * Fix various tests * Use errors.Is to check for io.EOF * Fix imports for v13 * fix: Do not wrap io.EOF intercepted by stream Sends (#37647) * Verify that intercepted stream Sends wrap io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends * Use a helper func, fix duplicate Send/Recv calls * Fix typo
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
* fix: Do not attempt relogin on remote BadParameter errors (#36866) * fix: Do not attempt relogin on trace.BadParameterError * Special case remote errors in IsErrorResolvableWithRelogin * Do not wrap Recv EOF errors * Fix various tests * Use errors.Is to check for io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends (#37647) * Verify that intercepted stream Sends wrap io.EOF * fix: Do not wrap io.EOF intercepted by stream Sends * Use a helper func, fix duplicate Send/Recv calls * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid wrapping
io.EOFwhen returned by stream Sends, as these are often used as guards in plain==or!=comparisons.Fixes "failed to close stream" logs observed in the wild.
Complements #36866.
Changelog: Fix "failed to close stream" log messages