[v15] Reuse tunnel resolvers instead of creating one per connection attempt #37718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `CachingResolver` is backed by a `FnCache` but does not expose a way to close the underlying cache. This leads to memory leaks as captured in #37025. Instead of modifying the resolver to allow explicit cleanup to occur, the resolvers were refactored to be created once per process instead of per connenction attempt to the cluster. Since the cluster address is read from the config file, it won't be changed for the duration of the process which allows us to safely use a single resolver. The one potential downside to this approach is the cache may return possibly stale errors during an outage until the entry is TTLed. Fixes #37025
github-actions
bot
added
backport
machine-id
size/sm
tctl
strideynet
approved these changes
Feb 2, 2024
zmb3
approved these changes
Feb 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #37566 to branch/v15
changelog: Fixed memory leak in tbot caused by never closing reverse tunnel address resolvers