[v14] backport #37520 and #37981 #37918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the request context, not session Dont pass websocket by context lint resolve some comments Add TestWSAuthenticateRequest Close ws in handler deprecation notices, doc resolve comments resolve comments give a longer read/write deadline dont set write deadline, ws endpoints never did before and it breaks things convert frontend to use ws access token Resolove comments, move to using an explicit state fix ci reset read deadline prettier update connectToHost linter read errors from websocket missing /ws on ttyWsAddr and fix wrong onmessage fix race in test lint skip TestTerminal as it takes 11 seconds to run dont skip the test resolve apiserver comments Add an AuthenticatedWebSocket class convert other clients to use AuthenticatedWebSocket Converts `AuthenticatedWebSocket` into drop-in replacement for `WebSocket` (#37699) * Converts `AuthenticatedWebSocket` into drop-in replacement for `WebSocket` that automatically goes through Teleport's custom authentication process before facilitating any caller-defined communication. This also reverts previous-`WebSocket` users to their original state (sans the code for passing the bearer token in the query string), swapping in `AuthenticatedWebSocket` in place of `WebSocket`. Create a single authnWsUpgrader with a comment justifying why we turn off CORS recieving to receiving resolve comments
github-actions
bot
requested review from
ibeckermayer,
jakule,
r0mant,
rosstimothy,
ryanclark and
zmb3
ibeckermayer
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Note: we forgot to update the desktop playback endpoint in the parent PR, we should refrain from cutting a release with this commit until #37981 is merged (and backported).
lxea
force-pushed
the
lxea/websocket-bearer-token-v14
branch
from
7f21a4f
to
f7e91eb
Compare
ibeckermayer
changed the title
|
Converting this to a draft for now, since it requires some major surgery to get it in order. |
|
closed in favor of #38070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #37520 and #37981
changelog: Removes access tokens from URL parameters, preventing them from being leaked to DNS servers, ISPs and other intermediary systems that may log them in plaintext.