Adds the extended keycode where appropriate and updates to the latest IronRDP master commit hash. #37962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IronRDP master commit hash.
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
ibeckermayer
commented
Feb 8, 2024
Comment on lines
+467
to
+470
| let extended = key.code & 0xE000 == 0xE000; | ||
| if extended { | ||
| flags |= KeyboardFlags::EXTENDED; | ||
| } |
There was a problem hiding this comment.
This is where we actually set the EXTENDED flag; the rest of the changes are to interface with the updated IronRDP apis.
zmb3
approved these changes
Feb 8, 2024
probakowski
approved these changes
Feb 8, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
gzdunek
This required a change to the state management for DesktopSession. State is still quite complex to get right here, but this is a step in the right direction.
…digm as it was forgotten in #37520
|
@zmb3 @probakowski Please take another look. I ended up needing to include some pretty substantive changes in order to pipe messages through to the client itself. I also realize we forgot to swap in the desktopplayback endpoint in #37962 new authenticated websocket paradigm, so those changes are included now as well. |
|
Are changes around playback ws the same here as in #37981? If so would it make sense to based this PR on top of that one? |
ibeckermayer
force-pushed
the
isaiah/update-ironrdp-latest
branch
from
73befee
to
2c550c7
Compare
zmb3
reviewed
Feb 11, 2024
zmb3
approved these changes
Feb 15, 2024
That may have been the case when you asked the question, but everything should be up to date now. |
probakowski
approved these changes
Feb 20, 2024
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
added a commit
that referenced
this pull request
Feb 27, 2024
… IronRDP master commit hash. (#37962) * Adds the extended keycode where appropriate and updates to the latest IronRDP master commit hash. * cleaning up disconnect result * Pipes disconnect messages through to the client. This required a change to the state management for DesktopSession. State is still quite complex to get right here, but this is a step in the right direction. * Updates desktopPlaybackHandle to the new authenticated websocket paradigm as it was forgotten in #37520 * prettier formatting * adding clarifying comments * Further refactoring to make DesktopSession's state machine more comprehensible * Remove unnecessary items from dependency lists
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Bump the rust group with 2 updates (#37739) Bumps the rust group with 2 updates: [tokio](https://github.com/tokio-rs/tokio) and [time](https://github.com/time-rs/time). Updates `tokio` from 1.35.1 to 1.36.0 - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.35.1...tokio-1.36.0) Updates `time` from 0.3.31 to 0.3.34 - [Release notes](https://github.com/time-rs/time/releases) - [Changelog](https://github.com/time-rs/time/blob/main/CHANGELOG.md) - [Commits](time-rs/time@v0.3.31...v0.3.34) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production update-type: version-update:semver-minor dependency-group: rust - dependency-name: time dependency-type: direct:production update-type: version-update:semver-patch dependency-group: rust ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adds the extended keycode where appropriate and updates to the latest IronRDP master commit hash. (#37962) * Adds the extended keycode where appropriate and updates to the latest IronRDP master commit hash. * cleaning up disconnect result * Pipes disconnect messages through to the client. This required a change to the state management for DesktopSession. State is still quite complex to get right here, but this is a step in the right direction. * Updates desktopPlaybackHandle to the new authenticated websocket paradigm as it was forgotten in #37520 * prettier formatting * adding clarifying comments * Further refactoring to make DesktopSession's state machine more comprehensible * Remove unnecessary items from dependency lists * Fix sticky windows key (#38198) * Adds the extended keycode where appropriate and updates to the latest IronRDP master commit hash. * cleaning up disconnect result * Pipes disconnect messages through to the client. This required a change to the state management for DesktopSession. State is still quite complex to get right here, but this is a step in the right direction. * Updates desktopPlaybackHandle to the new authenticated websocket paradigm as it was forgotten in #37520 * prettier formatting * adding clarifying comments * Further refactoring to make DesktopSession's state machine more comprehensible * Remove unnecessary items from dependency lists * Adds the KeyboardHandler class that manages the keyboard events, including new functionality to handle withholding the Windows/Alt keys to prevent such keys from "sticking" when the user switches between windows. This technique works to stop the sticking, though there is still an edge case where the user cmd/alt-tabs super quickly, in a manner that the browser sees both the down and up events for the Windows key, despite the user's intention being to change windows. In the case of the Windows key, this causes the start menu to pop open, and the user must press the Windows key again to close it. This is not a showstopper, but it is a bit annoying. A similar problem would occur with the Alt key, where such behavior would cause the current window (on the Windows machine) to focus on the menu bar. The next commit will be to add a timeout mechanism for the relevant keyup events in order to mitigate this edge case. * Adds a delayUp cache for delaying the up event of the sticky windows key. This is to prevent the edge case where the user presses cmd/alt-tab really quickly in a manner that causes the down + up events to be registered in spite of the user's intention to be to change out of the window. * Refactoring KeyboardHandler * Convert caches into Maps * Moves the rest of keyboard functionality into KeyboardHandler, rearranges methods, adds an onUnmount for clearing all the intervals on unmount * Moves KeyboardHandler to its own file * simplifies withholding logic by including a Withholder class with a single array that manages all the withheld keystrokes * Makes useEffect symmetrical * Rename onUnmount to dispose * sp * Adds unit tests for Withholder * Splitting Withholder out into its own file * nits * CR * make fix-license --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both of these changes are necessary in order to get the windows key to work again.
Corresponds with Devolutions/IronRDP#364
changelog: Allow users to send the Windows key for desktop sessions.