[v14] Hardware key serial number attestation #38069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/md
tsh
espadolini
requested review from
tigrato and
rosstimothy
and removed request for
espadolini,
flyinghermit and
jakule
tigrato
approved these changes
Feb 12, 2024
rosstimothy
approved these changes
Feb 12, 2024
Base automatically changed from
joerger/v14/hardware-key-setting
to
branch/v14
February 12, 2024 18:59
* Add support for hardware key serial number attestation through user trait. * Modify AttestHardwareKey interface to return full attestation data * Add serial number to attestation data and verify it * Add unit test. * Address comments. * Don't accept partial matches. * Fix build and test errors.
Joerger
force-pushed
the
joerger/v14/yubikey-serial-number-attestation
branch
from
32bb934
to
ed8c883
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #37728 to branch/v14
Changelog: Add option to validate hardware key serial numbers with hardware key support.