[v13] tsh: fix panic when loading profile #38303
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unmarshaling the profile YAML, it's possible for the unmarshal to complete without error while not populating the profile struct, which leads to a panic. Fix the nil pointer dereference by unmarshaling into a Profile instead of a *Profile, and further improve the error message when this happens. Fixes #38188
espadolini
approved these changes
Feb 15, 2024
rosstimothy
approved these changes
Feb 15, 2024
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38197 to branch/v13
changelog: Fixed a potential panic in the
tsh statuscommand.