[v13] tsh: skip invalid profiles instead of failing #38512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tsh status command attempts to decode one profile per YAML file in $TSH_HOME. If an error is encountered along the way, the entire command fails and tsh does not display information about any profiles. An especially confusing corner case is when a user mistakenly places tsh's configuration at $TSH_HOME/config.yaml instead of $TSH_HOME/config/config.yaml. In this case, the config file is assumed to be a profile and the user is presentedc with a confusing error message. Fix this by skipping over profiles that fail to load but continuing to report on the ones that load successfully. Closes #38302
Joerger
approved these changes
Feb 21, 2024
hugoShaka
approved these changes
Feb 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #38330 to branch/v13
changelog: Ensured that tsh continues to function if one of its profiles is invalid.