Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Set resource request/limit on wait-auth-update initContainer #38672

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

webvictim
Copy link
Contributor

@webvictim webvictim commented Feb 27, 2024

Fixes #37476

changelog: Resource limits are now correctly applied to the wait-auth-update initContainer in the teleport-cluster Helm chart.

@webvictim webvictim added helm no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels Feb 27, 2024
@webvictim webvictim self-assigned this Feb 27, 2024
@webvictim webvictim removed the no-changelog Indicates that a PR does not require a changelog entry label Feb 27, 2024
tigrato
tigrato previously approved these changes Feb 27, 2024
@tigrato tigrato dismissed their stale review February 27, 2024 14:59

I didn't realize that we were reusing the same resources as the proxy itself

@webvictim webvictim changed the title helm: Propagate resources to wait-auth-update initContainer helm: Set resource request/limit on wait-auth-update initContainer Feb 27, 2024
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@webvictim webvictim added this pull request to the merge queue Feb 27, 2024
Merged via the queue into master with commit 044acae Feb 27, 2024
35 of 36 checks passed
@webvictim webvictim deleted the gus/helm/add-resources-to-default-initcontainer branch February 27, 2024 18:51
@public-teleport-github-review-bot

@webvictim See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support resource limits for wait-auth-update container
3 participants