Fixes smartcard cancel regression #38742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the IronRDP refactor the smartcard cancel functionality was broken by forgetting to always return a response for the `SCARD_IOCTL_CANCEL` request itself, along with the response for the cancelled `SCARD_IOCTL_GETSTATUSCHANGEW`. This commit fixes that.
ibeckermayer
force-pushed
the
isaiah/fix-sc-cancel-regression
branch
2 times, most recently
from
0b21d3f
to
7a76aea
Compare
zmb3
approved these changes
Feb 29, 2024
r0mant
approved these changes
Feb 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
|
@ibeckermayer See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the IronRDP refactor the smartcard cancel functionality was broken by forgetting to always return a response for the
SCARD_IOCTL_CANCELrequest itself, along with the response for the cancelledSCARD_IOCTL_GETSTATUSCHANGEW. This commit fixes that.We also update the IronRDP hash, as well as our
RUST_VERSIONwhich is necessary to make use of the latest IronRDP hash (which uses a feature that was nightly-only on our previousRUST_VERSION, but which is now upstreamed to stable). Depends on:CloneandPartialEqon most of efs and esc Devolutions/IronRDP#388changelog: Fixes a regression that had reintroduced long freezes for certain actions like "Run as different user".