Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DynamoDB BatchWriteItemInput items limit #38743

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix DynamoDB BatchWriteItemInput items limit #38743

merged 2 commits into from
Feb 28, 2024

Conversation

smallinsky
Copy link
Contributor

@smallinsky smallinsky commented Feb 28, 2024 •
edited

What

From DynamoDB docs:

A single call to BatchWriteItem can transmit up to 16MB of data over the network, consisting of up to 25 item put or delete operations.

In the result when DeleteRange is called on a range with more than 25 items the DynamoDB operation returns following error:

Map value must satisfy constraint: [Member must have length less than or equal to 25, Member must have length greater than or equal to 1] status code: 400, request id: ...

Change the batch size to 25 to meet the dynamoDB constraints.

changelog: Fixed issue where DynamoDB writes could fail when recording too many records

@smallinsky smallinsky force-pushed the smallinsky/fix_dynamodb_batch_limit branch from 2b1f017 to 5583679 Compare February 28, 2024 18:46
@smallinsky smallinsky marked this pull request as ready for review February 28, 2024 18:47
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

espadolini
espadolini approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we not hit this in the past 5 years?

espadolini
espadolini approved these changes Feb 28, 2024
View reviewed changes
lib/backend/test/suite.go Outdated Show resolved Hide resolved
@smallinsky smallinsky force-pushed the smallinsky/fix_dynamodb_batch_limit branch from 5583679 to 4a82fd8 Compare February 28, 2024 20:39
@smallinsky smallinsky added this pull request to the merge queue Feb 28, 2024
Merged via the queue into master with commit 8be29ee Feb 28, 2024
34 checks passed
@smallinsky smallinsky deleted the smallinsky/fix_dynamodb_batch_limit branch February 28, 2024 21:58
@public-teleport-github-review-bot
Copy link

@smallinsky See the table below for backport results.

Branch Result
branch/v13 Create PR
branch/v14 Create PR
branch/v15 Create PR

This was referenced Feb 28, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espadolini espadolini espadolini approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

Assignees
No one assigned
Labels
backport/branch/v13 backport/branch/v14 backport/branch/v15 size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smallinsky @espadolini @fspmarshall @rosstimothy