Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Assume Start Time Validation #39008

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Fix Assume Start Time Validation #39008

merged 5 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Remove incorrect client validation

    @kimlisa
    kimlisa committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    fb4f261 View commit details
    Browse the repository at this point in the history

  2. Use consistent date time display

    @kimlisa
    kimlisa committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e0ace0a View commit details
    Browse the repository at this point in the history

  3. Create start time validation helper

    @kimlisa
    kimlisa committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a8197de View commit details
    Browse the repository at this point in the history

  4. Add validation checks 

    The following allows modifying the start time and is where
validation is placed:

- CreateAccessRequestV2
- SubmitAccessReview
- SetAccessRequestState (used with tctl)
    @kimlisa
    kimlisa committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    3629b2a View commit details
    Browse the repository at this point in the history

  5. Address Crs

    @kimlisa
    kimlisa committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0e0c0d1 View commit details
    Browse the repository at this point in the history