Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap gRPC calls in createClient to allow passing the errors over the context bridge #39230

Merged
merged 12 commits into from
Mar 18, 2024
Merged

Wrap gRPC calls in createClient to allow passing the errors over the context bridge #39230

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0c8ef85
Regenerate protos with the `protobuf-ts` client
gzdunek Mar 12, 2024
aad4a7d
Enable `strictBindCallApply` so `.bind()` results have correct types …
gzdunek Mar 12, 2024
ed50634
Use `protobuf-ts` client instead of `grpc-js` one
gzdunek Mar 12, 2024
dba0633
Convert `createClient` to use `protobuf-ts` response style, clone eac…
gzdunek Mar 12, 2024
f7cf8ac
Switch callsites to `cloneAbortSignal`
gzdunek Mar 12, 2024
3c0d7a4
Replace `error.message` checks with a proper check on the error statu…
gzdunek Mar 12, 2024
72956af
Merge branch 'gzdunek/cloneable-client' into grzdunek/wrap-grpc-calls
gzdunek Mar 14, 2024
1f02ef5
Clone the entire client instead of each method separately
gzdunek Mar 14, 2024
2e8608a
Correct the error `cause` in `ResourceSearchError`
gzdunek Mar 14, 2024
d2c79a5
Remove `params.sortBy` defaults, always set `startKey` to string
gzdunek Mar 14, 2024
343d53a
Merge branch 'gzdunek/cloneable-client' into grzdunek/wrap-grpc-calls
gzdunek Mar 18, 2024
e5982b3
Use a simpler type for `reportUsageEvent`
gzdunek Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ docs/theme/js/theme.js linguist-vendored=false
*_pb.d.ts linguist-generated
*_pb.ts linguist-generated
*_pb.grpc-*.ts linguist-generated
*_pb.client.ts linguist-generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you'll have to update the bot as well, see gravitational/shared-workflows#220.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder about updating the bot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will open a PR soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gravitational/shared-workflows#234

26 changes: 13 additions & 13 deletions buf-ts.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
version: v1
plugins:
- name: typescript
out: gen/proto/ts
opt: long_type_number,eslint_disable,add_pb_suffix,client_grpc1,server_grpc1,ts_nocheck
path:
- npm
- exec
- --yes
- --package=@protobuf-ts/plugin@2.9.3
- --
- protoc-gen-ts
strategy: all
version: v1
plugins:
- name: typescript
out: gen/proto/ts
opt: long_type_number,eslint_disable,add_pb_suffix,server_grpc1,ts_nocheck
path:
- npm
- exec
- --yes
- --package=@protobuf-ts/plugin@2.9.3
- --
- protoc-gen-ts
strategy: all
2 changes: 1 addition & 1 deletion gen/proto/ts/google/protobuf/descriptor_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/google/protobuf/duration_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/google/protobuf/empty_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/google/protobuf/field_mask_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/google/protobuf/timestamp_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

31 changes: 15 additions & 16 deletions ...o/ts/prehog/v1/teleport_pb.grpc-client.ts → gen/proto/ts/prehog/v1/teleport_pb.client.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/prehog/v1/teleport_pb.grpc-server.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/prehog/v1/teleport_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 57 additions & 0 deletions gen/proto/ts/prehog/v1alpha/connect_pb.client.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

58 changes: 0 additions & 58 deletions gen/proto/ts/prehog/v1alpha/connect_pb.grpc-client.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion gen/proto/ts/prehog/v1alpha/connect_pb.grpc-server.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion gen/proto/ts/prehog/v1alpha/connect_pb.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 57 additions & 0 deletions gen/proto/ts/prehog/v1alpha/tbot_pb.client.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.