[v15] ensure moderated file transfers only perform allowed operations #39351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capnspacehook
added
backport
server-access
sftp
capnspacehook
changed the title
* ensure moderated file transfers only preform allowed operations * fix sess test * wip integration test * integration test working * tweak some error messages and test cases * allow setstat for uploads * address nits from code review * expand paths when necessary when creating file transfer request * improve UX of errors in web UI * deny request when an invalid user tries to transfer files * don't allow open requests, they aren't done by the webui * address feedback * use a buffered reader when reading the file request, address a few nits
capnspacehook
force-pushed
the
capnspacehook/backport/v15/39091
branch
from
f2ed1aa
to
53d1fff
Compare
zmb3
approved these changes
Mar 14, 2024
Tener
approved these changes
Mar 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from avatus
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39091 and #39343.
changelog: only allow necessary operations during moderated file transfers and limit in-flight file transfer requests to one per session