Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] feat: adds relay_state to SAMLIdPServiceProviderSpecV1 #39401

Merged
merged 1 commit into from Mar 18, 2024

Conversation

flyinghermit
Copy link
Contributor

This PR:

  • Adds configurable relay_state field to the SAMLIdPServiceProviderSpecV1.
  • Defines a default relay state for supported GCPWorkforce service provider preset. The default value will be used if the preset type is specified but the relay_state field is empty.

During SAML authentication process, the value of relay_state will be added to SAML IdP initiated login as relay_state HTTP parameter.

Manually tested by signing into with GCP Workforce Identity Federation with IdP initiated flow.

Issue #39076

changelog: SAML IdP service provider spec now supports configurable relay_state field. This field can be used to define relay_state parameter for IdP initiated SAML authentication flow. For supported preset service provider types, a default value will be applied if the field is not configured.

@flyinghermit
Copy link
Contributor Author

Manual backport of #39276

@flyinghermit flyinghermit requested review from gzdunek and smallinsky and removed request for Tener and kimlisa March 15, 2024 15:08
@flyinghermit flyinghermit added this pull request to the merge queue Mar 18, 2024
Merged via the queue into branch/v15 with commit 670a5c5 Mar 18, 2024
37 checks passed
@flyinghermit flyinghermit deleted the sshah/backport-saml-idp-relay-state-39276 branch March 18, 2024 15:00
@fheinecke fheinecke mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants