[v14] Quote user supplied inputs provided to scripts to avoid RCE #39838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Quote user supplied inputs provided to scripts to avoid RCE This change introduces the func `utils.UnixShellQuote` which will quote any inputs which could potentially allow execution or script escape. This is utilized to ensure that scripts produced from a potential Phishing link could not contain code execution which may expose a user. * awsAccessGraphOIDCSync: Ensure role parameter is quoted correctly * join_tokens: Move shell quote to `getJoinScript` rather than where parameters are extracted This will increase safety moving forward, but it requires a more conservative quoting strategy.
rosstimothy
approved these changes
Mar 26, 2024
tigrato
approved these changes
Mar 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
marcoandredinis
approved these changes
Mar 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #39644 to branch/v14 (minor conflicts with missing aws join implementations)
changelog: Fix for possible phishing links which could result in code execution with install and join scripts