New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine ID: Database Tunnel service #39880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
approved these changes
Mar 29, 2024
gzdunek
approved these changes
Apr 3, 2024
public-teleport-github-review-bot
bot
removed the request for review
from timothyb89
April 3, 2024 07:51
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 3, 2024
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Apr 3, 2024
* Add Database Tunnel service config * Start putting together the alpnproxy * Further flesh out database tunnel service * Reorganize and tidy * Rearrange to avoid state on struct * Tidy up logging * Cache proxypings better * Spell Cancel the american way * Remove unnecessary change to client credential output * Add integration test for db access tunnel * Fix mistakenley renamed trace * Fix test panicking * Remove unnecessary boolean field
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Machine ID: Database Tunnel service (#39880) * Add Database Tunnel service config * Start putting together the alpnproxy * Further flesh out database tunnel service * Reorganize and tidy * Rearrange to avoid state on struct * Tidy up logging * Cache proxypings better * Spell Cancel the american way * Remove unnecessary change to client credential output * Add integration test for db access tunnel * Fix mistakenley renamed trace * Fix test panicking * Remove unnecessary boolean field * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36291
Adds a service to
tbot
which opens an authenticated database access tunnel without needing to run a separate process as previously.Benefits:
Example config:
changelog: Adds the
database-tunnel
service totbot
which allows an authenticated database tunnel to be opened bytbot
. This is an improvement over the original technique of usingtbot proxy db
.