Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15] Wrap diag service listener with multiplexer so it can work behind PROXY enabled loadbalancer/proxy. #40138

Merged
merged 7 commits into from
Apr 2, 2024
Merged

[v15] Wrap diag service listener with multiplexer so it can work behind PROXY enabled loadbalancer/proxy. #40138

merged 7 commits into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. Wrap diag service listener with multiplexer so it can work behind PRO… 

    …XY enabled loadbalancer/proxy.

It accept simultaneously connections that are prepended with PROXY line or not.
We also don't issue warnings about unspecified PROXY protocol mode for this listener.
    @AntonAM
    AntonAM authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    7eaea19 View commit details
    Browse the repository at this point in the history

  2. Fix wording. 

    Co-authored-by: Gus Luxton <gus@goteleport.com>
    @AntonAM @webvictim
    2 people authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bfd4a3e View commit details
    Browse the repository at this point in the history

  3. Use ExitContext instead of GracefulExitContext 

    Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
    @AntonAM @espadolini
    2 people authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1f3b98c View commit details
    Browse the repository at this point in the history

  4. Close diag multiplexer listener during diagnostic.shutdown event.

    @AntonAM
    AntonAM authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    ccd1f3b View commit details
    Browse the repository at this point in the history

  5. Refactor server.Serve() call

    @AntonAM
    AntonAM authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8d9ce57 View commit details
    Browse the repository at this point in the history

  6. Move creation of muxListener outside of diagnostic.service event.

    @AntonAM
    AntonAM authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    f2f53bd View commit details
    Browse the repository at this point in the history

  7. Combine declaration and usage 

    Co-authored-by: Edoardo Spadolini <edoardo.spadolini@goteleport.com>
    @AntonAM @espadolini
    2 people authored and github-actions committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    e0aa350 View commit details
    Browse the repository at this point in the history