Connection list: Hide cluster name for single cluster #40262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
commented
Apr 5, 2024
| padding: ${props => props.theme.space[1]}px | ||
| ${props => props.theme.space[2]}px; | ||
| // Space out items more if there are two lines of text to show inside a single item. | ||
| margin-block-start: ${props => |
There was a problem hiding this comment.
This is similar to gap but is defined on a child rather than a parent.
Well, it is similar to gap when called like this:
.stack > * + * {
margin-block-start: 1.5rem;
}…so that it's not applied to the first item in the list, but here it doesn't matter anyway.
I used it here since the parent in question is <ul> without display: flex. Perhaps using display: flex on <ul> is fine, but I didn't want to spend time on figuring out if it breaks anything related to list-specific spacing (e.g. list-style-type). Let me know if you know though!
There was a problem hiding this comment.
I think using display: flex on <ul> shouldn't break anything, but I'm fine with keeping it as is.
gzdunek
approved these changes
Apr 8, 2024
ryanclark
approved these changes
Apr 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@ravicious See the table below for backport results.
|
This was referenced Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Teleport Connect now hides cluster name in the connection list if there's only a single cluster available
Just a small cleanup. Many of our users log in just to a single cluster, presumably it has no leaf clusters as well. As such, we just end up repeating the cluster name which offers little value. See an example from an actual customer.
This PR makes it so that the cluster name is no longer shown when there's only a single cluster in
clustersServiceand the connections come just from a single cluster as well.Comparing how identical data is displayed between those two versions:
The list is a little more condensed, mostly because the vertical padding was changed from 6px to a standard 4px.