Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v15] chore: Bump github.com/sigstore/cosign/v2 to 2.2.4 #40497

Merged
merged 2 commits into from Apr 15, 2024

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Apr 11, 2024

Manual backport of #40485 to branch/v15.

Changelog: Updated cosign to address CVE-2024-29902 and CVE-2024-29903

@codingllama
Copy link
Contributor Author

This touches quite a lot of deps, so I gotta say it makes me a bit uneasy. WDYT?

@tigrato
Copy link
Contributor

tigrato commented Apr 15, 2024

This touches quite a lot of deps, so I gotta say it makes me a bit uneasy. WDYT?

These CVEs might affect our use-case for cosign and are mainly important for users that use custom registries. If an attacker gains the ability of overriding the image they can cause denied of service.
I think we should go ahead and update them.

What do you think @hugoShaka ?

@hugoShaka
Copy link
Contributor

I'm in favor of doing the update to fix the CVE, especially because the updater doesn't have memory limits by default.

I walked through all the changelogs for 0.x direct dependencies are did not find anything obvious that would break for us.

However, this PR causes an OTEL schema bump, and we end up with two conflicting schemas.

=== Failed
=== FAIL: lib/observability/tracing TestTraceProvider/not_sampling_prevents_exporting (0.01s)
    tracing_test.go:363: 
        	Error Trace:	/__w/teleport/teleport/lib/observability/tracing/tracing_test.go:363
        	Error:      	Received unexpected error:
        	            	1 errors occurred detecting resource:
        	            		* conflicting Schema URL: https://opentelemetry.io/schemas/1.21.0 and https://opentelemetry.io/schemas/1.24.0
        	Test:       	TestTraceProvider/not_sampling_prevents_exporting

@codingllama
Copy link
Contributor Author

Yes, there are problems with otel, I'll chase those in the near future.

@codingllama codingllama force-pushed the codingllama/bump-cosign-2.2.4-v15 branch from 8d95808 to 13ad166 Compare April 15, 2024 17:25
@codingllama codingllama added this pull request to the merge queue Apr 15, 2024
Merged via the queue into branch/v15 with commit c9030d5 Apr 15, 2024
34 checks passed
@codingllama codingllama deleted the codingllama/bump-cosign-2.2.4-v15 branch April 15, 2024 20:18
@camscale camscale mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants