Fix Windows pointer #40639
Fix Windows pointer #40639
Conversation
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
@ravicious @ibeckermayer friendly ping |
| @@ -1169,6 +1169,7 @@ fn create_config(params: &ConnectParams, pin: String) -> Config { | |||
| autologon: true, | |||
| pointer_software_rendering: false, | |||
| performance_flags: PerformanceFlags::default() | |||
| | PerformanceFlags::DISABLE_CURSOR_SHADOW // this is required for pointer to work correctly in Windows 2019 | |||
There was a problem hiding this comment.
Wireshark is showing me a value of 0x00000086 here with FreeRDP, which is PerformanceFlags(DISABLE_FULLWINDOWDRAG | DISABLE_MENUANIMATIONS | ENABLE_FONT_SMOOTHING).
Does this issue reproduce with FreeRDP?
| cursor.width = pointer.data.width; | ||
| cursor.height = pointer.data.height; | ||
| cursor | ||
| .getContext('2d', { colorSpace: pointer.data.colorSpace }) | ||
| .putImageData(pointer.data, 0, 0); | ||
| if (pointer.data.width > 32 || pointer.data.height > 32) { | ||
| // scale the cursor down to at most 32px - max size fully supported by browsers |
There was a problem hiding this comment.
We currently tell the server we can handle up to 384x384px cursors. Maybe it would be better not to advertise for that?
|
@ibeckermayer @probakowski I would like to see this merged today so that it goes in the next release. What are we missing in order to make that happen? |
|
As per conversation in Slack we'll go with the disabling shadows for now until we update IronRDP to commit including Devolutions/IronRDP#444 |
|
Update just for reference: has @probakowski's changes which fix the pointer disappearing issue. Those are merged, however we cannot update to IronRDP's to fix licensing issues. As a temporary solution, I have merged IronRDP (I will work on getting Devolutions/IronRDP#436 merged and then updating rev to IronRDP |
public-teleport-github-review-bot
bot
removed the request for review
from ravicious
|
@probakowski See the table below for backport results.
|
* Fix Windows pointer * Use default flags * comment * update IronRDP, enable shadow * Revert "update IronRDP, enable shadow" This reverts commit 0d7acf3. * Update IronRDP
This PR fixes couple of problems with pointer in desktop access:
PointerHiddenandPointerDefaultmessagesDISABLE_CURSOR_SHADOWperformance flag)Fixes #39986
changelog: Fix Windows cursor getting stuck