Reduce parallelism when polling from AWS APIs #40775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
tigrato
added
backport/branch/v14
no-changelog
jakule
reviewed
Apr 22, 2024
| // This is a temporary solution until we have a better way to limit the | ||
| // number of concurrent requests. | ||
| eG.SetLimit(10) | ||
| eG.SetLimit(5) |
There was a problem hiding this comment.
- Should we make this configurable?
- Does AWS has different rate limits for different accounts? If yes, this change will help some and make stuff slower for other.
There was a problem hiding this comment.
- No
- Yes and it depends if you requested an API quota increase. Once we move to SDK V2, I can implement a proper retry and rate limiter but until then we are kind of limited on what we can do.
jakule
approved these changes
Apr 22, 2024
|
@tigrato IMO this should be include in the release notes. Something like "reduce the number of concurrent requests to AWS API to reduce the rate limiting errors". |
avatus
approved these changes
Apr 23, 2024
tigrato
removed
the
no-changelog
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce parallelism when polling AWS APIs and add a retry definition
Changelog: Reduce parallelism when polling AWS resources to prevent API throttling when exporting them to Teleport Access Graph