[v15] fix: prevent deleting AWS OIDC integration used by EAS #40851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
camscale,
espadolini and
marcoandredinis
|
I still need to add the condition to check that auth servers on an older minor/patch version are not holding the lock #40630 (comment) edit: done in 4a60e0d |
espadolini
approved these changes
Apr 24, 2024
|
I will update the e ref to include https://github.com/gravitational/teleport.e/pull/4018 before merging this |
rosstimothy
approved these changes
Apr 24, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
camscale
The External Audit Storage feature for Teleport Cloud depends on an AWS OIDC integration to exist in order to get credentials for the customer AWS account. It's currently possible for a customer to delete the AWS OIDC integration referenced by the EAS configuration, leading to the EAS integration breaking and the Auth service crashing the next time it's started up. This commit prevents deleting an AWS OIDC integration currently referenced by and EAS integration, and prevents creating an EAS integration referencing an unknown AWS OIDC integration.
nklaassen
force-pushed
the
bot/backport-40630-branch/v15
branch
from
4a60e0d
to
23fcd11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40630 to branch/v15
changelog: prevent deleting AWS OIDC integration used by External Audit Storage.