[v15] Issue cert.create events during device authentication #40872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add DeviceExtensions to the events.Identity proto * Update generated protos * Issue cert.create events during device authentication
codingllama
commented
Apr 24, 2024
Comment on lines
-2907
to
-2923
| eventIdentity := identity.GetEventIdentity() | ||
| eventIdentity.Expires = notAfter | ||
| if err := a.emitter.EmitAuditEvent(a.closeCtx, &apievents.CertificateCreate{ | ||
| Metadata: apievents.Metadata{ | ||
| Type: events.CertificateCreateEvent, | ||
| Code: events.CertificateCreateCode, | ||
| }, | ||
| CertificateType: events.CertificateTypeUser, | ||
| Identity: &eventIdentity, | ||
| ClientMetadata: apievents.ClientMetadata{ | ||
| //TODO(greedy52) currently only user-agent from GRPC clients are | ||
| //fetched. Need to propagate user-agent from HTTP calls. | ||
| UserAgent: trimUserAgent(metadata.UserAgentFromContext(ctx)), | ||
| }, | ||
| }); err != nil { | ||
| log.WithError(err).Warn("Failed to emit certificate create event.") | ||
| } |
There was a problem hiding this comment.
We got a conflict here, but the blocks look identical to me (compare with emitCertCreateEvent).
The other conflict was in the generated protos file.
gabrielcorado
approved these changes
Apr 24, 2024
rosstimothy
approved these changes
Apr 24, 2024
public-teleport-github-review-bot
bot
removed the request for review
from probakowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #40848 to branch/v15.
Changelog: Issue cert.create events during device authentication