Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Support Agentless connections with Hardware Key support #40929

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Apr 25, 2024

Backport #39267 and #38994 to branch/v14

* Add fake yubikey private key implementation for tests.

* Add TestHardwareKeyLogin.

* Simplify Hardware Key support test plan.

* Enable piv test package in tests.

* Add TestMarshalAndParsePrivateKey.

* Address simple comments.

* Remove *testing.T from mockSSOLogin in; Add and use better helper methods for mocking sso login.

* Refactor test to dynamically set mock attestation data; revert related changes.
@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Apr 25, 2024
@github-actions github-actions bot added backport documentation size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport. labels Apr 25, 2024
@Joerger Joerger changed the title [v14] Add e2e tests for Hardware Key support [v14] Support Agentless connections with Hardware Key support Apr 26, 2024
@Joerger
Copy link
Contributor Author

Joerger commented Apr 26, 2024

@zmb3 @r0mant Can I get a /excludeflake * - timeout caused by refactors to test helpers in #38994

Edit: found out we don't need it for release branches, sorry for the ping

@Joerger
Copy link
Contributor Author

Joerger commented Apr 26, 2024

@ptgott can I get a docs approval for this backport?

@Joerger Joerger added this pull request to the merge queue Apr 26, 2024
Merged via the queue into branch/v14 with commit 27bc62f Apr 26, 2024
36 of 37 checks passed
@Joerger Joerger deleted the bot/backport-39267-branch/v14 branch April 26, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/md tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants