Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] fix: Forbid SSO users from logging in using passwordless #41071

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

codingllama
Copy link
Contributor

@codingllama codingllama commented Apr 30, 2024

Backport #41062 to branch/v14.

Changelog: Fixed user SSO bypass by performing a local passwordless login

* Save the WebAuthn UserHandle in the mock Key

* Simplify passwordless tests

* fix: Forbid SSO users from logging in using passwordless

* Rename tests to TestPasswordlessProhibitedForSSO
@codingllama codingllama changed the title [v14] fix: Forbid SSO users from logging in using passwordless () [v14] fix: Forbid SSO users from logging in using passwordless Apr 30, 2024
Copy link
Contributor Author

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few conflicts on this one:

  • webLogin.Finish returns 3 values, not 2
  • GetUser doesn't take a context
  • No extensions available on CreateAuthenticateChallengeRequest

@codingllama
Copy link
Contributor Author

Oh, and tool/tctl/common/admin_action_test.go doesn't exist here.

@codingllama codingllama added this pull request to the merge queue Apr 30, 2024
Merged via the queue into branch/v14 with commit e4e5f46 Apr 30, 2024
28 of 29 checks passed
@codingllama codingllama deleted the codingllama/backport/41062-v14 branch April 30, 2024 20:43
@camscale camscale mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants