-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback to cache.GetAccessList call #41258
Conversation
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
5cb3a17
to
1018558
Compare
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
@smallinsky See the table below for backport results.
|
What
Issue: https://github.com/gravitational/teleport.e/issues/3938
CreateAccessList and AddAccessListMember flow depends on the cache propagation.
Add a fallback call for
GetAccessList
to prevent cache miss during fast chainedCreateAccessList
AddAccessListMember
calls where access list needs to be present in cache during handling theAddAccessListMember
call.This is the same approach like CreateRole(Role: X) CreateUser(User[Role: X] where during user creation validaditon check if role x exist by doing a fallback call:
teleport/lib/cache/cache.go
Line 1935 in 5cb3a17
Access List Flow:
It creates a empty access list https://github.com/gravitational/teleport.e/blob/master/lib/okta/accesslistsync.go#L319
upsertAccessListMember
call fails with AccessDenied errorchangelog: Add fallback on GetAccessList cache miss call