Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] Fix glob matched role access requests when generating system annotations #41938

Merged
merged 2 commits into from
May 23, 2024

Conversation

nklaassen
Copy link
Contributor

@nklaassen nklaassen commented May 23, 2024

Backport #41907 to branch/v13

Changelog: fixed access request annotations when annotations contain globs, regular expressions, trait expansions, or claims_to_roles is used.

…notations

Backport #41907 to branch/v13

Co-authored-by: Nic Klaassen <nic@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant May 23, 2024 02:06
@nklaassen nklaassen enabled auto-merge May 23, 2024 02:21
@nklaassen nklaassen added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@r0mant r0mant added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@r0mant r0mant added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@r0mant r0mant added this pull request to the merge queue May 23, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
…notations (#41938)

* [v13] Fix glob matched role access requests when generating system annotations

Backport #41907 to branch/v13

Co-authored-by: Nic Klaassen <nic@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>

* use x/exp/slices

---------

Co-authored-by: Alex McGrath <alex.mcgrath@goteleport.com>
Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@nklaassen nklaassen added this pull request to the merge queue May 23, 2024
Merged via the queue into branch/v13 with commit e9490ed May 23, 2024
22 checks passed
@nklaassen nklaassen deleted the nklaassen/v13/glob-annotations-fix branch May 23, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants