Log debug error if user cleanup is a not found error from missing getent binaries
#42373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxea
added
no-changelog
zmb3
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Should our docs mention that host user operations won't work in distroless containers?
Should we check on startup whether the required tools are available and disable functionality that we know is not going to work?
There was a problem hiding this comment.
Makes sense to me, pushed this
It doesn't mention it in the context of distroless containers but it does mention that it wont work unless the required binaries are in the path
lxea
force-pushed
the
lxea/fix-cleanup-logging
branch
from
869c365
to
f36392a
Compare
gzdunek
approved these changes
Jun 10, 2024
|
@zmb3 do you mind giving this another quick look over, thanks! |
zmb3
approved these changes
Jun 11, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41918