fdpass: send stderr to tbot for error diagnostics #43547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
reviewed
Jun 26, 2024
| b := make([]byte, 1) | ||
| fds := make([]*os.File, 1) | ||
|
|
||
| // TODO(espadolini): get rid of [uds.Conn] |
There was a problem hiding this comment.
Does this TODO need addressing ?
There was a problem hiding this comment.
Not in this PR, but there's only drawbacks to having a wrapper around *net.UnixConn, especially if what we're doing with them is io.Copying data around.
strideynet
approved these changes
Jun 26, 2024
timothyb89
approved these changes
Jun 26, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@espadolini See the table below for backport results.
|
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates fdpass and tbot to pass the fdpass stderr file descriptor to tbot so that it can be used by tbot to output error messages. The file descriptor is not required (so fdpass doesn't necessarily have to be updated, and, in fact, this PR doesn't update the behavior of
tbot ssh-multiplexer-proxy-command) and a file descriptor sent over the socket will just get discarded (and thus closed) if tbot wasn't updated to receive it.changelog: improved error diagnostics when using Machine ID's SSH multiplexer