Backport: Prevent a panic in tsh kube login when logged out #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
a-palchikov,
fspmarshall,
klizhentas,
r0mant,
russjones and
webvictim
as code owners
Turns out, client.Status can return a nil error *and* profile. Handle nil profile separately and return a simple error.
awly
force-pushed
the
andrew/5.0/kube_login_no_profile
branch
from
ce3a01a
to
85df2ef
Compare
a-palchikov
approved these changes
Nov 18, 2020
|
Better fix coming in #4893 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4885 into 5.0
Fixes #4884