Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom environment variables in PAM with SSO interpolation #6158

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

xacrimon
Copy link
Contributor

Similar to #6087 which was delayed due to a pending discussion about dynamic configuration.

@xacrimon xacrimon added feature-request Used for new features in Teleport, improvements to current should be #enhancements PAM Label related to Pluggable Authentication Module (PAM) Submethod. backport-required labels Mar 25, 2021
@xacrimon xacrimon requested a review from russjones March 25, 2021 20:24
@xacrimon xacrimon self-assigned this Mar 25, 2021
@xacrimon xacrimon added this to the 6.1 milestone Mar 25, 2021
@xacrimon xacrimon enabled auto-merge (rebase) March 25, 2021 20:58
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xacrimon Needs test coverage.

docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
lib/srv/reexec.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Show resolved Hide resolved
@russjones
Copy link
Contributor

russjones commented Mar 26, 2021

@xacrimon Forgot to tell you this before, to test this you can update the PAM modules we currently use in tests:

https://github.com/gravitational/teleport/tree/master/build.assets/pam
https://github.com/gravitational/teleport/blob/master/integration/integration_test.go#L3198-L3334

@xacrimon
Copy link
Contributor Author

@russjones added test coverage

docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/pages/features/ssh-pam.mdx Outdated Show resolved Hide resolved
docs/testplan.md Outdated Show resolved Hide resolved
lib/config/fileconf.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
lib/config/fileconf.go Outdated Show resolved Hide resolved
lib/pam/config.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from russjones March 26, 2021 17:42
lib/srv/ctx.go Outdated Show resolved Hide resolved
lib/srv/ctx.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-required feature-request Used for new features in Teleport, improvements to current should be #enhancements PAM Label related to Pluggable Authentication Module (PAM) Submethod.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants