Emit session end event when completer finishes upload #6756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinqu
force-pushed
the
jane/emit-session-end-upload-completer
branch
from
c9952cd
to
3d2ac0c
Compare
quinqu
force-pushed
the
jane/emit-session-end-upload-completer
branch
from
58144cd
to
c44d922
Compare
quinqu
force-pushed
the
jane/emit-session-end-upload-completer
branch
from
5fc3f93
to
c89a63c
Compare
tcsc
reviewed
May 7, 2021
fspmarshall
approved these changes
May 10, 2021
xacrimon
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose is to emit a
session.endevent when the upload completer uploads the session. As stated in the issue below, it makes it hard to locate the session without this event.Also, when
session_recordingis in sync mode and the node dies/becomes disconnected during a session, the session recording will still show up in the web UIFixes #6606, #6125
Implementation
Get session events from the
UploadCompleteraudit log, ifsession.enddoes not exist -- fill in field values needed forsession.end, then emit the event.