Reset event checkpoint key property for non sub-page breaks #7638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
approved these changes
Jul 22, 2021
nklaassen
approved these changes
Jul 22, 2021
xacrimon
force-pushed
the
joel/fix-7635
branch
2 times, most recently
from
c18c091
to
4c211ad
Compare
|
@xacrimon Please backport this to branch/v6.2 as well. |
|
@russjones will do, need approval |
|
@xacrimon Can you add test coverage? |
|
@russjones I tried. To break this you need a lot of events and it times out long before that finishes. I had Lisa test it manually too with the frontend. |
xacrimon
force-pushed
the
joel/fix-7635
branch
2 times, most recently
from
4c211ad
to
a675389
Compare
|
@xacrimon Was that the local DynamoDB emulator? |
|
@russjones It was not, nothing in the test infra is set up to work with that atm. |
xacrimon
force-pushed
the
joel/fix-7635
branch
2 times, most recently
from
e376a21
to
c129a0f
Compare
|
@russjones Added test coverage, managed to make it work. |
xacrimon
added a commit
that referenced
this pull request
Jul 29, 2021
xacrimon
added a commit
that referenced
this pull request
Jul 29, 2021
xacrimon
added a commit
that referenced
this pull request
Jul 29, 2021
xacrimon
added a commit
that referenced
this pull request
Jul 29, 2021
xacrimon
added a commit
that referenced
this pull request
Aug 2, 2021
xacrimon
added a commit
that referenced
this pull request
Aug 2, 2021
xacrimon
added a commit
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7635 which was introduced in #7266 and is caused by incorrect event skipping logic for resuming from sub-page breaks in the events iterator in Dynamo. It doesn't remedy the incorrect event return amount since that is a designed cutoff to avoid hitting gRPC message limits but it does fix the somewhat rare pagination end bug that the issue also mentions.