Go 1.17: Stop using ; as a separator in URL query strings #8143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.17 (by default) disallows using ; as a separator. Our tests fail on Go 1.17 with the following error. Since we only do this in test code, it's easiest just to switch to & so we don't have a breakage when we start compiling with 1.17. See also: golang/go#25192 Error: 2021/09/03 10:21:57 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192 ---------------------------------------------------------------------- FAIL: apiserver_test.go:473: WebSuite.TestSAMLSuccess apiserver_test.go:524: c.Assert(u.Scheme+"://"+u.Host+u.Path, Equals, fixtures.SAMLOktaSSO) ... obtained string = ":///web/msg/error/login" ... expected string = "https://dev-813354.oktapreview.com/app/gravitationaldev813354_teleportsaml_1/exkafftca6RqPVgyZ0h7/sso/saml"
codingllama
approved these changes
Sep 3, 2021
zmb3
added a commit
that referenced
this pull request
Sep 23, 2021
Go 1.17 (by default) disallows using ; as a separator. Our tests fail on Go 1.17 with the following error. Since we only do this in test code, it's easiest just to switch to & so we don't have a breakage when we start compiling with 1.17. See also: golang/go#25192 Error: 2021/09/03 10:21:57 http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192 ---------------------------------------------------------------------- FAIL: apiserver_test.go:473: WebSuite.TestSAMLSuccess apiserver_test.go:524: c.Assert(u.Scheme+"://"+u.Host+u.Path, Equals, fixtures.SAMLOktaSSO) ... obtained string = ":///web/msg/error/login" ... expected string = "https://dev-813354.oktapreview.com/app/gravitationaldev813354_teleportsaml_1/exkafftca6RqPVgyZ0h7/sso/saml"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.17 (by default) disallows using
;as a separator, which causes our tests to fail on Go 1.17.Go 1.17 also includes an escape hatch to revert to the legacy behavior, but it's a new API and would prevent our code from compiling on 1.16. Since we only do this in test code, it's easiest just to switch to
&so we don't have a breakage when we start compiling with 1.17.See also: golang/go#25192
Error: