Deduplicate access request IDs before signing certificates #9453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
approved these changes
Dec 17, 2021
smallinsky
approved these changes
Dec 17, 2021
espadolini
force-pushed
the
espadolini/access-requests-dedup
branch
from
1d80844
to
58bb61d
Compare
This was referenced Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An user with an approved access request
<request_id>could repeatedly calltsh login --request-id=<request_id>and accumulate multiple copies of the same access request in their ssh certificate, so we just deduplicate the IDs before proceeding with the checks and the issuance.As a bonus, we also display the current active requests (if any) in the output of
tsh status.