Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google.golang.org/grpc to v1.43.0 #9656

Merged
merged 2 commits into from Jan 10, 2022
Merged

Conversation

rosstimothy
Copy link
Contributor

@rosstimothy rosstimothy commented Jan 5, 2022

Update grpc dependency to the latest version. Needed to fix the client side hang that
prevents TwoClustersTunnel from running succesfully.

Fixes #9655.

Update grpc dependency to the latest version. Needed to fix the client side hang that
prevents TwoClustersTunnel from running succesfully, see #9655.
@rosstimothy rosstimothy changed the title update grpc Update google.golang.org/grpc to v1.43.0 Jan 10, 2022
@rosstimothy rosstimothy marked this pull request as ready for review January 10, 2022 18:58
Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to make update-vendor when backporting.

@rosstimothy rosstimothy merged commit 95d0f0d into master Jan 10, 2022
@rosstimothy rosstimothy deleted the tross/grpc_update branch January 10, 2022 20:36
rosstimothy added a commit that referenced this pull request Jan 11, 2022
rosstimothy added a commit that referenced this pull request Jan 12, 2022
rosstimothy added a commit that referenced this pull request Jan 12, 2022
* backport #9656 to branch/v8
russjones added a commit that referenced this pull request Jan 15, 2022
TestTwoClustersTunnel has legitimately been failing for many months.
However, we've been re-running integration tests until it passes.

On master and branch/v8 we've fixed the issue by upgrading etcd and
grpc dependency.

#9656
#9607

Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by
updating etcd and grpc, but as these branches are meant to be fairly
stable at this point, and the risk of unintended consequences by
updating etcd and grpc feels too high.
russjones added a commit that referenced this pull request Jan 19, 2022
TestTwoClustersTunnel has legitimately been failing for many months.
However, we've been re-running integration tests until it passes.

On master and branch/v8 we've fixed the issue by upgrading etcd and
grpc dependency.

#9656
#9607

Ideally we'd fix TestTwoClustersTunnel on branch/6.2 and branch/v7 by
updating etcd and grpc, but as these branches are meant to be fairly
stable at this point, and the risk of unintended consequences by
updating etcd and grpc feels too high.
@webvictim webvictim mentioned this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tunnel auth clients appear to become stuck in bad state on restart
3 participants