feat!: Make IsAggregate work with Go-wrapped errors #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should close the cycle on trace changes, after that we can tag the next version and update Teleport. Are we OK bundling the behavioral changes here into |
codingllama
force-pushed
the
codingllama/aggregate
branch
from
d560807
to
edbc550
Compare
|
Fixed an issue with (the original iteration of) edbc550, another issue with IsNotFound and added IsError tests for aggregates. |
rosstimothy
approved these changes
Aug 4, 2023
Comment on lines
+808
to
+810
| assert.True(t, IsBadParameter(errAggregate), "IsBadParameter aggregate mismatch") | ||
| assert.True(t, IsNotFound(errAggregate), "IsNotFound aggregate mismatch") | ||
| assert.False(t, IsConnectionProblem(errAggregate), "IsConnectionProblem aggregate mismatch") |
zmb3
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally missed from #95.
I've done a few other tweaks to existing code, but only is IsAggregate and Errors are visibly-changed (other methods may be slightly more performant).
I've also added "IsError" tests for aggregated errors and fixed an issue where our custom IsNotFound logic didn't call
As(any) bool.