-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Make IsAggregate work with Go-wrapped errors #97
Conversation
This should close the cycle on trace changes, after that we can tag the next version and update Teleport. Are we OK bundling the behavioral changes here into |
d560807
to
edbc550
Compare
Fixed an issue with (the original iteration of) edbc550, another issue with IsNotFound and added IsError tests for aggregates. |
assert.True(t, IsBadParameter(errAggregate), "IsBadParameter aggregate mismatch") | ||
assert.True(t, IsNotFound(errAggregate), "IsNotFound aggregate mismatch") | ||
assert.False(t, IsConnectionProblem(errAggregate), "IsConnectionProblem aggregate mismatch") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😲 🎉
Originally missed from #95.
I've done a few other tweaks to existing code, but only is IsAggregate and Errors are visibly-changed (other methods may be slightly more performant).
I've also added "IsError" tests for aggregated errors and fixed an issue where our custom IsNotFound logic didn't call
As(any) bool
.