This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
[v11] Fix websocket close (#1463) #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #1442 we added a close code when closing websockets, but didn't properly adhere to the API. When explicitly setting a close code, you must either use the normal code or use a custom code. Usage of the standard codes in the 1001-1015 range is reserved for the browser. Fixes gravitational/teleport#19688 Co-authored-by: Isaiah Becker-Mayer <isaiah@goteleport.com>
zmb3
approved these changes
Dec 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backports #1463 to teleport-v11