feat(oidc): support POST end_session_endpoint (logout) #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcompiegne
force-pushed
the
issues/#6643-post-logout-endpoint
branch
from
bd151d6
to
b334490
Compare
leleueri
requested changes
Dec 3, 2021
There was a problem hiding this comment.
I did a quick review of the code base (I will do another hit later) but during my tests I found following issues :
- when the "single sign out" is enabled, the op_id_token is present into the AM id_token, is it expected ? Until now, we filter thisi attribute
- when the "single sign out" is enabled, If I call the logout endpoint using GET method and the id_token_hint parameter, the External IDP (Azure AD) rises and error. (The logout on azure work if the id_token_hint isn't provided)
|
as discussed on slack, these two issues are not related to this PR. |
leleueri
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gravitee-io/issues#6643