Fixed not encode certificate header #4016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgw-gravitee
reviewed
May 9, 2024
...ain/java/io/gravitee/am/gateway/handler/oauth2/resources/auth/provider/CertificateUtils.java
Show resolved
Hide resolved
lgw-gravitee
approved these changes
May 9, 2024
move to chain replaceAll("\t", "\n")
tcompiegne
added
apply-on-4-1-x
apply-on-master
apply-on-4-0-x
apply-on-4-2-x
apply-on-4-3-x
apply-on-4-4-x
and removed
apply-on-4-2-x
labels
tcompiegne
approved these changes
May 10, 2024
This was referenced May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃啍 Reference related issue.
from AWS gateway to certificate header value add not encrypted chars like "", "/","="
as result certificate not valid.
鉁忥笍 A description of the changes proposed in the pull request
add replaceAll
"+" to "%2F"
"//" to "%2B"
"=" to "%3D"
馃摑 Test scenarios
to certificate add not encrypted "" or "/" or "="
and try by class CertificateUtils#extractPeerCertificate
receive certificate
馃捇 Add screenshots for UI
馃摎 Any other comments that will help with documentation
馃懆 馃懇@mentions of the person or team responsible for reviewing proposed changes
This is a nice example: #1822