fix: check top api parameter when deleting top apis

This closes gravitee-io/issues#1131

gravitee-management-api-service/src/main/java/io/gravitee/management/service/ParameterService.java

@@ -18,6 +18,7 @@
 import io.gravitee.repository.management.model.Parameter;
 
 import java.util.List;
+import java.util.Optional;
 import java.util.function.Function;
 import java.util.function.Predicate;
 
@@ -33,6 +34,8 @@ public interface ParameterService {
 
     <T> List<T> findAll(String key, Function<String, T> mapper, Predicate<String> filter);
 
+    Optional<Parameter> findByKey(String key);
+
     Parameter create(String key, String value);
 
     void createMultipleValue(String key, String value);

gravitee-management-api-service/src/main/java/io/gravitee/management/service/impl/ParameterServiceImpl.java

@@ -60,6 +60,17 @@ public class ParameterServiceImpl extends TransactionalService implements Parame
     @Inject
     private AuditService auditService;
 
+    @Override
+    public Optional<Parameter> findByKey(String key) {
+        try {
+            return parameterRepository.findById(key);
+        } catch (final TechnicalException ex) {
+            final String message = "An error occurs while trying to find parameter with key: " + key;
+            LOGGER.error(message, ex);
+            throw new TechnicalManagementException(message, ex);
+        }
+    }
+
     @Override
     public List<String> findAll(final String key) {
         return findAll(key, value -> value, null);

gravitee-management-api-service/src/main/java/io/gravitee/management/service/impl/TopApiServiceImpl.java

@@ -98,9 +98,11 @@ public List<TopApiEntity> update(final List<UpdateTopApiEntity> topApis) {
 
     @Override
     public void delete(final String apiId) {
-        final List<TopApiEntity> topApis = findAll();
-        topApis.removeIf(topApiEntity -> apiId.equals(topApiEntity.getApi()));
-        parameterService.updateMultipleValue(PORTAL_TOP_APIS.getKey(),
-                topApis.stream().sorted(comparing(TopApiEntity::getOrder)).map(TopApiEntity::getApi).collect(toList()));
+        if (parameterService.findByKey(PORTAL_TOP_APIS.getKey()).isPresent()) {
+            final List<TopApiEntity> topApis = findAll();
+            topApis.removeIf(topApiEntity -> apiId.equals(topApiEntity.getApi()));
+            parameterService.updateMultipleValue(PORTAL_TOP_APIS.getKey(),
+                    topApis.stream().sorted(comparing(TopApiEntity::getOrder)).map(TopApiEntity::getApi).collect(toList()));
+        }
     }
 }

gravitee-management-api-service/src/test/java/io/gravitee/management/service/TopApiServiceTest.java

@@ -20,6 +20,7 @@
 import io.gravitee.management.model.TopApiEntity;
 import io.gravitee.management.model.UpdateTopApiEntity;
 import io.gravitee.management.service.impl.TopApiServiceImpl;
+import io.gravitee.repository.management.model.Parameter;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
@@ -31,6 +32,7 @@
 import static io.gravitee.management.service.impl.ParameterKeys.PORTAL_TOP_APIS;
 import static java.util.Arrays.asList;
 import static java.util.Collections.singletonList;
+import static java.util.Optional.of;
 import static org.junit.Assert.assertEquals;
 import static org.mockito.Matchers.any;
 import static org.mockito.Matchers.eq;
@@ -139,6 +141,7 @@ public void shouldDelete() {
         final ApiEntity api2 = new ApiEntity();
         api2.setId("2");
 
+        when(parameterService.findByKey(PORTAL_TOP_APIS.getKey())).thenReturn(of(new Parameter()));
         when(parameterService.findAll(eq(PORTAL_TOP_APIS.getKey()), any(), any())).thenReturn(asList(api1, api2));
 
         topApiService.delete("1");