This repository has been archived by the owner on Oct 20, 2021. It is now read-only.
feat: newsletter improvment #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytvnr
force-pushed
the
issues/#4692_newsletter_improvment
branch
2 times, most recently
from
d2e6e30
to
428b8e6
Compare
gcusnieux
reviewed
Jan 21, 2021
src/index.scss
Outdated
| @@ -30,7 +30,7 @@ $backgroundColor: #fdfdfd; | |||
| @import 'components/error/error'; | |||
| @import 'components/import/import-api'; | |||
| @import 'components/navbar/navbar'; | |||
| @import 'components/newsletter-subcription/newsletter-subscription'; | |||
| @import 'src/components/newsletter-subcription/newsletter-reminder'; | |||
There was a problem hiding this comment.
it's strange to add 'src' ...
gcusnieux
reviewed
Jan 21, 2021
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| } |
There was a problem hiding this comment.
I think that's not necessary, should be part by component
There was a problem hiding this comment.
resolved in pair programming !
gcusnieux
suggested changes
Jan 21, 2021
|
|
||
| this.newsletterPage = document.querySelector('gv-newsletter-subscription'); | ||
| this.newsletterPage.addEventListener('gv-newsletter-subscription:subscribe', this.onSubscribe.bind(this)); | ||
| this.newsletterPage.addEventListener('gv-newsletter-subscription:skip', this.onSkip.bind(this)); |
There was a problem hiding this comment.
If you want, the good syntax to add listeners in template is :
ng-on-gv-newsletter:subscribe="$ctrl.onSubscribe($event)"
There was a problem hiding this comment.
as discussed, we will keep as is since this component is simple and we set a property directly here
ytvnr
force-pushed
the
issues/#4692_newsletter_improvment
branch
from
428b8e6
to
82ea1d5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gravitee-io/issues#4692