This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
updates to latest versions of all actors #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brasseld
reviewed
Jul 5, 2019
| @@ -0,0 +1,169 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Why providing this binary instead of using the one from the container?
There was a problem hiding this comment.
Hi,
i tried to make less changes as possible respect to the initial master so due the fact in the original binary there is the following code:
if [ -f "/etc/gravitee-gateway/gravitee.yml" ]
then
GRAVITEE_OPTS="-Dgravitee.conf=/etc/gravitee-gateway/gravitee.yml"
fi
the configuration supplied from outside the container wasn't read
So, I had to change as follow:
if [ -f "$GRAVITEEIO_HOME/config/gravitee.yml" ]
then
GRAVITEE_OPTS="-Dgravitee.conf=$GRAVITEEIO_HOME/config/gravitee.yml"
fi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to make the projects compliants with the latest versions of all actors